[
https://issues.apache.org/jira/browse/LUCENE-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674312#comment-16674312
]
Tomoko Uchida commented on LUCENE-2562:
---------------------------------------
I created another pull request for review, could you take a look this.
[https://github.com/apache/lucene-solr/pull/490]
I fixed the code to pass ant validation tasks, following your comments.
(This time, Luke module passes most of the validations,
validate-source-patterns, forbiddenapis, check-lib-versions and so on. Also
unit tests seem to be more stable than before.)
{quote}1. validate-source-patterns complains about non-static-final loggers:
{quote}
The code of the PR has passed {{validate-source-patterns}} on my PC (MacBook /
Java 1.8.0_181).
{quote}2. It should be possible to run Luke from a source checkout, but it's
not now.
{quote}
{quote}3. I think Luke should be packaged with all other artifacts in Lucene's
binary packages, but currently ant package-tgz and -zip don't include everything
{quote}
{{luke/build.xml}} in this PR creates a simple directory structure as follows
in the tgz/zip packeges.
{code:java}
$ cd lucene-8.0.0-SNAPSHOT
$ tree -L 1 luke/
luke/
├── lib
├── lucene-luke-8.0.0-SNAPSHOT.jar
├── luke.bat // this does not exist yet (TBD).
└── luke.sh
{code}
{{luke.sh}} can be launched from anywhere. The script knows classpaths
(relative paths to jars it depends on) to run. I am not sure that this launch
script is the best design choice... if there are better ways to package Luke
with Lucene, please let me know.
{code:java}
# if you are in `lucene-8.0.0` directory:
$ ./luke/luke.sh
{code}
{quote}
4. forbidden-apis is very unhappy about classes in javafx.* packages
{quote}
Besides javafx, a bunch of fixes were needed to pass the check but now it has
passed forbiddedapis check.
----
I have some issues to ask or consult with you.
1. Luke is a GUI tool so I think Javadoc should not be published with the
tar/zip. I have tried to disable {{javadoc}} and {{documentation-lint}} task,
but adding this lines is not working. Am I missing something?
{{documentation-lint}} is failed so it does not pass {{ant precommit}}. :/
{code:java}
<target name="javadocs"/>
<target name="documentation-lint"/>
{code}
2. I have noticed that Guice (cglib) has a compatibility issue with JDK9+.
Please see [https://github.com/DmitryKey/luke/issues/125]
With the latest version of Guice (4.2.2), JDK 11 still emits the warnings.
We will be able to remove the dependency on Guice, but if possible I'd like to
use the DI framework to keep UI components and model classes loosely coupled.
(This greatly helped me when switching JavaFX to Swing, though I didn't expect
that situation.)
> Make Luke a Lucene/Solr Module
> ------------------------------
>
> Key: LUCENE-2562
> URL: https://issues.apache.org/jira/browse/LUCENE-2562
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Mark Miller
> Priority: Major
> Labels: gsoc2014
> Attachments: LUCENE-2562-Ivy.patch, LUCENE-2562-Ivy.patch,
> LUCENE-2562-Ivy.patch, LUCENE-2562-ivy.patch, LUCENE-2562.patch,
> LUCENE-2562.patch, Luke-ALE-1.png, Luke-ALE-2.png, Luke-ALE-3.png,
> Luke-ALE-4.png, Luke-ALE-5.png, luke-javafx1.png, luke-javafx2.png,
> luke-javafx3.png, luke1.jpg, luke2.jpg, luke3.jpg, lukeALE-documents.png
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> see
> "RE: Luke - in need of maintainer":
> http://markmail.org/message/m4gsto7giltvrpuf
> "Web-based Luke": http://markmail.org/message/4xwps7p7ifltme5q
> I think it would be great if there was a version of Luke that always worked
> with trunk - and it would also be great if it was easier to match Luke jars
> with Lucene versions.
> While I'd like to get GWT Luke into the mix as well, I think the easiest
> starting point is to straight port Luke to another UI toolkit before
> abstracting out DTO objects that both GWT Luke and Pivot Luke could share.
> I've started slowly converting Luke's use of thinlet to Apache Pivot. I
> haven't/don't have a lot of time for this at the moment, but I've plugged
> away here and there over the past work or two. There is still a *lot* to do.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
