Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/455#discussion_r231567341
  
    --- Diff: 
solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java 
---
    @@ -1164,6 +1225,31 @@ public void processGetUpdates(ResponseBuilder rb) 
throws IOException
         return new ArrayList<>(versionsToRet);
       }
     
    +  /**
    +   *  <p>
    +   *    Lookup strategy for {@link #getInputDocument(SolrCore, BytesRef, 
AtomicLong, Set, Resolution)}.
    +   *  </p>
    +   *  <ul>
    +   *    <li>{@link #FULL_DOC}</li>
    +   *    <li>{@link #DOC_CHILDREN}</li>
    +   *    <li>{@link #FULL_HIERARCHY}</li>
    +   *  </ul>
    +   */
    +  public static enum Resolution {
    --- End diff --
    
    Suggested new names:  "DOC", "DOC_WITH_CHILDREN", "ROOT_WITH_CHILDREN".
    Resolution is now only used where there is no "in place" so no need to 
mention partial documents.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to