Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/455#discussion_r231566214
  
    --- Diff: 
solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java
 ---
    @@ -259,9 +264,8 @@ public boolean doInPlaceUpdateMerge(AddUpdateCommand 
cmd, Set<String> updatedFie
         SolrInputDocument oldDocument = RealTimeGetComponent.getInputDocument
           (cmd.getReq().getCore(), idBytes,
            null, // don't want the version to be returned
    -       true, // avoid stored fields from index
            updatedFields,
    -       true); // resolve the full document
    +       RealTimeGetComponent.Resolution.FULL_DOC); // get the partial 
document for the in-place update
    --- End diff --
    
    it is not a partial document; the original comment was correct.  Now with 
an enum, we don't even need a comment as the enum has a self explanatory name.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to