I agree with Simon,
I’d prefer to just add jenkins jobs for the “http2” branch and not yet merge it. That’s possible to setup in short time. If the number of failures don’t grow beyond the current state, we can merge. If it get’s worse on same hardware, then we should not merge yet. The problem with Solr tests is that the reliability differs from hardware to hardware (because of some timing/multithreading issues). So to make a comparison, you should compare with and without patch on same hardware. I can setup a jenkins job on ASF jenkins and Policeman jenkins (copy of master job with different branch) and let it run. I can configure the dev mailing list or Cao Mạnh Đạt’s mail address there. What do you prefer? Uwe ----- Uwe Schindler Achterdiek 19, D-28357 Bremen http://www.thetaphi.de <http://www.thetaphi.de/> eMail: u...@thetaphi.de From: Simon Willnauer <simon.willna...@gmail.com> Sent: Monday, November 26, 2018 3:03 PM To: Lucene/Solr dev <dev@lucene.apache.org> Subject: Re: Poll: Merge jira/http2 to master branch I don't know what the state of the tests is for solr. I'm also not on top of your work so please correct me if I am wrong. You are saying you won't have enough time for the feature in the near future but you want to merge it still to master so others can chime in? I don't think this is an approach that works. I think if others need to chime in it should be done on the branch? My definition for being ready to be merged to master is that the code and tests are stable. If there are minor tasks to be done then I guess I am fine with that. To me this sounds like it will put a ton of work on somebody else plate? I mean mark is spending a lot of time on the tests and this would make his life even harder? I don't think we should do this. simon On Mon, Nov 26, 2018 at 12:08 PM Đạt Cao Mạnh <caomanhdat...@gmail.com <mailto:caomanhdat...@gmail.com> > wrote: Hi guys, The changes in jira/http2 branch is very close to be commit now, but the current state of tests make me quite nervous about merging. I have a local Jenkins job for testing jira/http2 and the result is quite bad so far. I'm not sure failures caused by jira/http2 changes or the master branch. I wish I have more time on hardening and debugging the failures in jira/http2 branch. But the recent changes in my job do not allow me to spend as much time as I want. Therefore I'm thinking about merging jira/http2 to the master branch now and with the support of the community we can make tests more reliable. (not just me watching and working on it). I know that Mark Miller is working on hardness tests, do you want me to wait for your work to be committed first? Thanks! -- Best regards, Cao Mạnh Đạt D.O.B : 31-07-1991 Cell: (+84) 946.328.329 E-mail: <mailto:caomanhdat...@gmail.com> caomanhdat...@gmail.com
