Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/528#discussion_r241967695
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedStandaloneUpdateProcessor.java
---
@@ -56,8 +59,15 @@ public void doDeleteByQuery(DeleteUpdateCommand cmd)
throws IOException {
super.doDeleteByQuery(cmd, Collections.emptyList(), null);
}
+ @Override
+ protected void postProcessDeleteByQuery(DeleteUpdateCommand cmd,
+ List<SolrCmdDistributor.Node>
replicas, DocCollection coll) throws IOException {
+ // no op
+ }
+
@Override
boolean isLeader(UpdateCommand cmd) {
+ updateCommand = cmd;
--- End diff --
Perhaps we should have another isLeader method that returns a boolean,
since the current method is used by other classes in the package to setup the
request and determine whether the core is the leader for the specified update
command.
I'll work on a patch ASAP.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
