Github user barrotsteindev commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/528#discussion_r243628041
  
    --- Diff: 
solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java
 ---
    @@ -425,4 +448,10 @@ void setupRequest(UpdateCommand cmd) {
           nodes = setupRequest(dcmd.getId(), null);
         }
       }
    +
    +  @Override
    +  protected boolean shouldCloneCmdDoc() {
    +    boolean willDistrib = isLeader && nodes != null && nodes.size() > 0;
    --- End diff --
    
    This could probably optimized, since cloneRequiredOnLeader is already set 
during construction of the instance:
    `if(!cloneRequiredOnLeader) {
        return false;
    }
    // will distrib command
    return isLeader && nodes != null && nodes.size() > 0;`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to