[
https://issues.apache.org/jira/browse/SOLR-12365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734929#comment-16734929
]
David Smiley commented on SOLR-12365:
-------------------------------------
I made the aforementioned changed. While looking at the class further, I saw
some luceneMatchVersion methods which clearly did not belong here since this
class is supposed to be generic for any XML file, not just solrconfig.xml in
particular. In the attached patch I move them to SolrConfig. Look good
[~janhoy]?
> Rename Config.java to XmlConfigFile.java to clarify it's use
> ------------------------------------------------------------
>
> Key: SOLR-12365
> URL: https://issues.apache.org/jira/browse/SOLR-12365
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: David Smiley
> Priority: Minor
> Attachments:
> move_luceneMatchVersion_parsing_to_SolrConfig_from_XmlConfigFile.patch
>
>
> Seeing "Config"; I was confused what sort of config it was. Turns out it's a
> wrapper around an XML document providing some convenience methods around it.
> It ought to have class javadocs too. XmlConfigFile would be a clearer name
> IMO.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
