[
https://issues.apache.org/jira/browse/SOLR-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735469#comment-16735469
]
David Smiley commented on SOLR-12888:
-------------------------------------
{quote}I liked how in TestNestedUpdateProcessor the "nested" URP chain is used,
having this processor explicitly added, while TestChildDocTransformerHierarchy
uses the default URP, ensuring this is activated implicitly.
{quote}
I think both tests are the same in this respect? At least this patch makes them
the same – both use the URP implicitly. Or am I missing something?
RE putIfAbsent vs computeIfAbsent: sure; I'll make this change. Yeah it's very
minor but might as well.
> NestedUpdateProcessor code should activate automatically in 8.0
> ---------------------------------------------------------------
>
> Key: SOLR-12888
> URL: https://issues.apache.org/jira/browse/SOLR-12888
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Blocker
> Fix For: master (8.0)
>
> Attachments: SOLR-12888.patch
>
>
> If the schema supports it, the NestedUpdateProcessor URP should be registered
> automatically somehow. The Factory for this already looks for the existence
> of certain special fields in the schema, so that's good. But the URP Factory
> needs to be added to your chain in any of the ways we support that. _In 8.0
> the user shouldn't have to do anything to their solrconfig._
> We might un-URP this and call directly somewhere. Or perhaps we might add a
> special named URP chain (needn't document), defined automatically, that
> activates at RunURP. Perhaps other things could be added to this in the
> future.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
