[
https://issues.apache.org/jira/browse/LUCENE-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742046#comment-16742046
]
Uwe Schindler commented on LUCENE-2562:
---------------------------------------
Hi Tomoko,
I would also favour to remove Guice, if it's easy to do. By the way, I opened
the CGLIB issue back at that time: https://github.com/cglib/cglib/issues/93
Some background: In early Java 9 version deep reflection was not working at
all, which was relaxed before release. The "official" statement is: CGLIB is no
longer maintained, people should migrate to ByteBuddy. Because of this we
removed all our Mocking frameworks (we had many in Solr) and moved everything
to Mockito. Mockito uses ByteBuddy and uses a more modern way to produce
proxies.
I really don't like to make Lucene depend on a library (CGLIB) that's no longer
maintained by the community. If we want to use Guice, Guice should move to
ByteBuddy. This is one reason why Elasticsearch dropped dependency injection
with Guice long ago. That's also too much magic and should be avoided.
+1 for the patch without Guice.
Once you are done, I will look over it again. I mentioned a small thing on the
Pull Request: Please don't allow writes to sysprops GLOBALLY! There is a reason
why tests are not allowed to do this. If You really need to set a system
property please document it and list those exemptions separately in the policy
file (with comment).
> Make Luke a Lucene/Solr Module
> ------------------------------
>
> Key: LUCENE-2562
> URL: https://issues.apache.org/jira/browse/LUCENE-2562
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Mark Miller
> Priority: Major
> Labels: gsoc2014
> Attachments: LUCENE-2562-Ivy.patch, LUCENE-2562-Ivy.patch,
> LUCENE-2562-Ivy.patch, LUCENE-2562-ivy.patch, LUCENE-2562.patch,
> LUCENE-2562.patch, Luke-ALE-1.png, Luke-ALE-2.png, Luke-ALE-3.png,
> Luke-ALE-4.png, Luke-ALE-5.png, luke-javafx1.png, luke-javafx2.png,
> luke-javafx3.png, luke1.jpg, luke2.jpg, luke3.jpg, lukeALE-documents.png,
> スクリーンショット 2018-11-05 9.19.47.png
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> see
> "RE: Luke - in need of maintainer":
> http://markmail.org/message/m4gsto7giltvrpuf
> "Web-based Luke": http://markmail.org/message/4xwps7p7ifltme5q
> I think it would be great if there was a version of Luke that always worked
> with trunk - and it would also be great if it was easier to match Luke jars
> with Lucene versions.
> While I'd like to get GWT Luke into the mix as well, I think the easiest
> starting point is to straight port Luke to another UI toolkit before
> abstracting out DTO objects that both GWT Luke and Pivot Luke could share.
> I've started slowly converting Luke's use of thinlet to Apache Pivot. I
> haven't/don't have a lot of time for this at the moment, but I've plugged
> away here and there over the past work or two. There is still a *lot* to do.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
