risdenk commented on a change in pull request #553: SOLR-9515: Update to Hadoop 
3
URL: https://github.com/apache/lucene-solr/pull/553#discussion_r251857862
 
 

 ##########
 File path: solr/core/src/test/org/apache/hadoop/http/HttpServer2.java
 ##########
 @@ -0,0 +1,1685 @@
+/*
 
 Review comment:
   This file is copied directly from Apache Hadoop to allow integration tests 
to run under Jetty 9.4.
   
   I couldn't find a way to get the shaded Hadoop dependencies (new in Hadoop 
3) to work since they shaded too much (like javax.servlet). This made our 
integration with hadoop-auth break.
   
   I have no idea if copying HttpServer2 in here will break other things. I 
tested with JDK 8 and so far this looks good.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to