risdenk commented on a change in pull request #553: SOLR-9515: Update to Hadoop 
3
URL: https://github.com/apache/lucene-solr/pull/553#discussion_r252415334
 
 

 ##########
 File path: solr/core/src/test/org/apache/solr/cloud/hdfs/HdfsTestUtil.java
 ##########
 @@ -67,6 +68,14 @@ public static MiniDFSCluster setupClass(String dir, boolean 
safeModeTesting, boo
     LuceneTestCase.assumeFalse("HDFS tests were disabled by 
-Dtests.disableHdfs",
       Boolean.parseBoolean(System.getProperty("tests.disableHdfs", "false")));
 
+    // Checks that commons-lang3 FastDateFormat works with configured locale
 
 Review comment:
   Currently certain locales like "ja-JP-u-ca-japanese-x-lvariant-JP" cause 
`FastDateFormat` from commons-lang3 to fail.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to