risdenk commented on a change in pull request #553: SOLR-9515: Update to Hadoop
3
URL: https://github.com/apache/lucene-solr/pull/553#discussion_r253094751
##########
File path: solr/core/src/test/org/apache/solr/cloud/hdfs/HdfsTestUtil.java
##########
@@ -62,73 +63,88 @@
public static MiniDFSCluster setupClass(String dir) throws Exception {
return setupClass(dir, true, true);
}
-
+
public static MiniDFSCluster setupClass(String dir, boolean haTesting)
throws Exception {
return setupClass(dir, haTesting, true);
}
-
+
+ /**
+ * Checks that commons-lang3 FastDateFormat works with configured locale
+ */
+ @SuppressForbidden(reason="Call FastDateFormat.format same way Hadoop calls
it")
+ private static void checkFastDateFormat() {
Review comment:
commons-lang3 has an issue with the locale
`ja-JP-u-ca-japanese-x-lvariant-JP` but this will catch if there are other
locales with issues.
http://mail-archives.apache.org/mod_mbox/commons-user/201901.mbox/%3CCAJU9nmhqgzh7VcxyhJNfb4czC2SvJzZd4o6ARcuD4msof1U2Zw%40mail.gmail.com%3E
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
