jpountz commented on a change in pull request #556: LUCENE-8673: Use radix
partitioning when merging dimensional points
URL: https://github.com/apache/lucene-solr/pull/556#discussion_r253373968
##########
File path:
lucene/core/src/java/org/apache/lucene/util/bkd/OfflinePointReader.java
##########
@@ -74,55 +69,68 @@ public OfflinePointReader(Directory tempDir, String
tempFileName, int packedByte
// at another level of the BKDWriter recursion
in = tempDir.openInput(tempFileName, IOContext.READONCE);
}
+
name = tempFileName;
long seekFP = start * bytesPerDoc;
in.seek(seekFP);
countLeft = length;
- packedValue = new byte[packedBytesLength];
- this.longOrds = longOrds;
+ if (reusableBuffer != null) {
Review comment:
then if we do that maybe we can remove the maxPointInHeap ctor argument and
compute it from this buffer size?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
