jpountz commented on a change in pull request #556: LUCENE-8673: Use radix partitioning when merging dimensional points URL: https://github.com/apache/lucene-solr/pull/556#discussion_r253380758
########## File path: lucene/core/src/java/org/apache/lucene/util/bkd/PointWriter.java ########## @@ -19,24 +19,30 @@ import java.io.Closeable; import java.io.IOException; -import java.util.List; + +import org.apache.lucene.util.BytesRef; /** Appends many points, and then at the end provides a {@link PointReader} to iterate * those points. This abstracts away whether we write to disk, or use simple arrays * in heap. * - * @lucene.internal */ -public interface PointWriter extends Closeable { - /** Add a new point */ - void append(byte[] packedValue, long ord, int docID) throws IOException; + * @lucene.internal + * */ +public interface PointWriter<T extends PointReader> extends Closeable { + /** Add a new point from byte array*/ + void append(byte[] packedValue, int docID) throws IOException; Review comment: do we still need this one, ie. could callers always call the method that takes a bytesref? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org