[
https://issues.apache.org/jira/browse/SOLR-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777613#comment-16777613
]
Erick Erickson commented on SOLR-13268:
---------------------------------------
Hmmm, SolrTestCaseJ4 has a LoggerFactory.getLogger in it. If the first test
case extends SolrTestCaseJ4 rather than LuceneTestCase, then that would be
consistent with your theory.
So maybe my initial fixes where I added the shutdown to SolrTestCaseJ4 then
extended from SolrTestCaseJ4 rather than LuceneTestCase was coincidental and
that extending that class _also_ defined a logger which was the thing that
actually made the difference.
Making all Solr test cases extend SolrTestCaseJ4 seems overkill, but perhaps
there's something we could add to LuceneTestCase? I'm thinking that the
shutdown process would be sensitive to a logger being defined (or not). But I
admit I have no idea _how_ to make that happen.
But that would give the Lucene devs heartburn, Lucene doesn't use logging.
Hmmmm2. Is it really that onerous to require that test cases extend
SolrTestCaseJ4 rather than LuceneTestCase?
> Clean up any test failures resulting from defaulting to async logging
> ---------------------------------------------------------------------
>
> Key: SOLR-13268
> URL: https://issues.apache.org/jira/browse/SOLR-13268
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
> Attachments: SOLR-13268.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> This is a catch-all for test failures due to the async logging changes. So
> far, the I see a couple failures on JDK13 only. I'll collect a "starter set"
> here, these are likely systemic, once the root cause is found/fixed, then
> others are likely fixed as well.
> JDK13:
> ant test -Dtestcase=TestJmxIntegration -Dtests.seed=54B30AC62A2D71E
> -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=lv-LV
> -Dtests.timezone=Asia/Riyadh -Dtests.asserts=true -Dtests.file.encoding=UTF-8
> ant test -Dtestcase=TestDynamicURP -Dtests.seed=54B30AC62A2D71E
> -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=rwk
> -Dtests.timezone=Australia/Brisbane -Dtests.asserts=true
> -Dtests.file.encoding=UTF-8
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
