[
https://issues.apache.org/jira/browse/SOLR-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778221#comment-16778221
]
Erick Erickson commented on SOLR-13268:
---------------------------------------
bq. Maybe only the async case spins up background threads and thats why the
shutdown has to be handled correctly?
That's certainly my guess. I'll see if I can trace through this with
synchronous logging. In the synchronous case I suspect it's a no-op, but I'll
check.
And the reproducing seed is a test case that derives from..... LuceneTestCase.
So if we do the @AfterClass thing, we can either
1> blanket-replace all the "extends LuceneTestCase" to "extends SolrTestCaseJ4"
or
2> play whack-a-mole for any of these that we see. Which is yucky.
or
3> run the tests with synchronous logging, which I also think is yucky.
If we do something like <1>, I'd like to have it become a precommit failure if
possible to keep it from creeping back.
I suppose in any extreme cases we can "somehow" allow a test case to subclass
LuceneTestCase, but I can't think of a good reason offhand.
> Clean up any test failures resulting from defaulting to async logging
> ---------------------------------------------------------------------
>
> Key: SOLR-13268
> URL: https://issues.apache.org/jira/browse/SOLR-13268
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
> Attachments: SOLR-13268.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> This is a catch-all for test failures due to the async logging changes. So
> far, the I see a couple failures on JDK13 only. I'll collect a "starter set"
> here, these are likely systemic, once the root cause is found/fixed, then
> others are likely fixed as well.
> JDK13:
> ant test -Dtestcase=TestJmxIntegration -Dtests.seed=54B30AC62A2D71E
> -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=lv-LV
> -Dtests.timezone=Asia/Riyadh -Dtests.asserts=true -Dtests.file.encoding=UTF-8
> ant test -Dtestcase=TestDynamicURP -Dtests.seed=54B30AC62A2D71E
> -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=rwk
> -Dtests.timezone=Australia/Brisbane -Dtests.asserts=true
> -Dtests.file.encoding=UTF-8
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
