[ https://issues.apache.org/jira/browse/LUCENE-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785989#comment-16785989 ]
Lucene/Solr QA commented on LUCENE-8712: ---------------------------------------- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 38s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green} 0m 32s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Check forbidden APIs {color} | {color:green} 0m 27s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Validate source patterns {color} | {color:green} 0m 27s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 15m 3s{color} | {color:green} core in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 17s{color} | {color:green} sandbox in the patch passed. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 19m 52s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | LUCENE-8712 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12961397/LUCENE-8712.patch | | Optional Tests | compile javac unit ratsources checkforbiddenapis validatesourcepatterns | | uname | Linux lucene1-us-west 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | ant | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh | | git revision | master / 5f91670 | | ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 | | Default Java | 1.8.0_191 | | Test Results | https://builds.apache.org/job/PreCommit-LUCENE-Build/172/testReport/ | | modules | C: lucene/core lucene/sandbox U: lucene | | Console output | https://builds.apache.org/job/PreCommit-LUCENE-Build/172/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > Polygon2D does not detect crossings in some cases > ------------------------------------------------- > > Key: LUCENE-8712 > URL: https://issues.apache.org/jira/browse/LUCENE-8712 > Project: Lucene - Core > Issue Type: Bug > Reporter: Ignacio Vera > Priority: Major > Attachments: LUCENE-8712.patch, LUCENE-8712.patch, LUCENE-8712.patch > > > Polygon2D does not detect crossing if the triangle crosses through points of > the polygon and none of the points are inside it. For example: > > {code:java} > public void testLineCrossingPolygonPoints() { > Polygon p = new Polygon(new double[] {0, -1, 0, 1, 0}, new double[] {-1, 0, > 1, 0, -1}); > Polygon2D polygon2D = Polygon2D.create(p); > PointValues.Relation rel = > polygon2D.relateTriangle(GeoEncodingUtils.decodeLongitude(GeoEncodingUtils.encodeLongitude(-1.5)), > GeoEncodingUtils.decodeLatitude(GeoEncodingUtils.encodeLatitude(0)), > GeoEncodingUtils.decodeLongitude(GeoEncodingUtils.encodeLongitude(1.5)), > GeoEncodingUtils.decodeLatitude(GeoEncodingUtils.encodeLatitude(0)), > > GeoEncodingUtils.decodeLongitude(GeoEncodingUtils.encodeLongitude(-1.5)), > GeoEncodingUtils.decodeLatitude(GeoEncodingUtils.encodeLatitude(0))); > assertEquals(PointValues.Relation.CELL_CROSSES_QUERY, rel); > }{code} > [~nknize] you might want to look at this as I am not sure what to do. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org