[ https://issues.apache.org/jira/browse/LUCENE-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790322#comment-16790322 ]
ASF subversion and git services commented on LUCENE-8712: --------------------------------------------------------- Commit 458205396efa160ec92829f45971103a0c4e6892 in lucene-solr's branch refs/heads/master from Ignacio Vera [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=4582053 ] LUCENE-8712: Polygon2D does not detect crossings in some cases (#598) LUCENE-8712: revert crossing logic to use boolean logic and skip lines over the dateline to support dateline crossing logic > Polygon2D does not detect crossings in some cases > ------------------------------------------------- > > Key: LUCENE-8712 > URL: https://issues.apache.org/jira/browse/LUCENE-8712 > Project: Lucene - Core > Issue Type: Bug > Reporter: Ignacio Vera > Priority: Major > Attachments: LUCENE-8712.patch, LUCENE-8712.patch, LUCENE-8712.patch > > Time Spent: 20m > Remaining Estimate: 0h > > Polygon2D does not detect crossing if the triangle crosses through points of > the polygon and none of the points are inside it. For example: > > {code:java} > public void testLineCrossingPolygonPoints() { > Polygon p = new Polygon(new double[] {0, -1, 0, 1, 0}, new double[] {-1, 0, > 1, 0, -1}); > Polygon2D polygon2D = Polygon2D.create(p); > PointValues.Relation rel = > polygon2D.relateTriangle(GeoEncodingUtils.decodeLongitude(GeoEncodingUtils.encodeLongitude(-1.5)), > GeoEncodingUtils.decodeLatitude(GeoEncodingUtils.encodeLatitude(0)), > GeoEncodingUtils.decodeLongitude(GeoEncodingUtils.encodeLongitude(1.5)), > GeoEncodingUtils.decodeLatitude(GeoEncodingUtils.encodeLatitude(0)), > > GeoEncodingUtils.decodeLongitude(GeoEncodingUtils.encodeLongitude(-1.5)), > GeoEncodingUtils.decodeLatitude(GeoEncodingUtils.encodeLatitude(0))); > assertEquals(PointValues.Relation.CELL_CROSSES_QUERY, rel); > }{code} > [~nknize] you might want to look at this as I am not sure what to do. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org