[
https://issues.apache.org/jira/browse/LUCENE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088705#comment-13088705
]
Robert Muir commented on LUCENE-3391:
-------------------------------------
a few comments:
* I think we should avoid the generics here? also I think the private sim
should be final.
* If the idea is to use for non-vector space sims, I think we should return 1
for coord() by default? in my tests it sometimes totally hoses the ranking for
e.g. probabilistic models.
* We can also rethink the naming in that regard? its just a Similarity provider
that always returns the same similarity?
> Make EasySimilarityProvider a full-fledged class
> -------------------------------------------------
>
> Key: LUCENE-3391
> URL: https://issues.apache.org/jira/browse/LUCENE-3391
> Project: Lucene - Java
> Issue Type: Sub-task
> Components: core/query/scoring, general/javadocs
> Reporter: David Mark Nemeskey
> Assignee: David Mark Nemeskey
> Labels: gsoc, gsoc2011, rank, similarity
> Fix For: flexscoring branch
>
> Attachments: LUCENE-3391.patch, LUCENE-3391.patch, LUCENE-3391.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The {{EasySimilarityProvider}} in {{TestEasySimilarity}} would be a good
> candidate for a full-fledged class. Both {{DefaultSimilarity}} and
> {{BM25Similarity}} have their own providers, which are effectively the
> same,so I don't see why we couldn't add one generic provider for convenience.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
