[
https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816623#comment-16816623
]
Erick Erickson commented on LUCENE-8738:
----------------------------------------
Been a busy couple of days, sorry I didn't get back to this sooner. This change
looks good. As far as simplifying... well, I have to hop in the "way back"
machine so it's fuzzy. I'll try to loop in someone who worked on a custom impl.
The critical bit is that over in SolrCores, there has to be synchronization
around updating "pendingCloses", and those sync methods shouldn't be exposed to
the impl. I don't think there's any good way for the transient impl to _get_
the solrCores object from CoreContainer (which it does have), and I don't think
exposing solrCores for just this is a good idea. So I hit on the Observer
pattern as an "end around" that problem and once it worked never went back and
thought about it again.
Looking at it with fresh eyes, though, it seems like adding the queueCoreClose
to coreContainer which _does_ have access to the solrCores object and can do
anything it wants with it in a controlled manner would solve that problem much
more simply. And the transient impl has access to coreContainer so.....
So AFAIC, let's rip the complexity out and replace it with a call. I agree that
doing that in a separate Jira is a good thing. But let's wait a bit to see if I
can loop in people who are living with the current setup.
Thanks for your work here!
Erick
> Bump minimum Java version requirement to 11
> -------------------------------------------
>
> Key: LUCENE-8738
> URL: https://issues.apache.org/jira/browse/LUCENE-8738
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/build
> Reporter: Adrien Grand
> Priority: Minor
> Labels: Java11
> Fix For: master (9.0)
>
> Attachments: LUCENE-8738-solr-CoreCloseListener.patch
>
>
> See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
