[
https://issues.apache.org/jira/browse/LUCENE-8793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833542#comment-16833542
]
Tomoko Uchida commented on LUCENE-8793:
---------------------------------------
[~jun_o]: thanks for the nice patch!
I did some sanity checks locally. First of all, this works for me by the ant
target: {{ant -f lucene/luke/build.xml run}} :)
I noticed a few things:
1. Javadocs linter failed, so {{ant precommit}} also failed.
{code:java}
-documentation-lint:
[echo] checking for broken html...
[jtidy] FIXME: Broken HTML checks were disabled, as jtidy can't handle
HTML5.
[echo] Checking for broken links...
[exec]
[exec] Crawl/parse...
[exec]
[exec] Verify...
[echo] Checking for missing docs...
[exec]
[exec]
build/docs/luke/org/apache/lucene/luke/app/desktop/components/fragments/analysis/package-summary.html
[exec] missing description:
SimpleAnalyzeResultPanelOperator.TokensTableModel
[exec] missing description: SimpleAnalyzeResultPanelProvider
[exec] missing description:
StepByStepAnalyzeResultPanelOperator.NamedTokensTableModel
[exec] missing description: StepByStepAnalyzeResultPanelProvider
[exec]
[exec] Missing javadocs were found!
BUILD FAILED
{code}
But we can delay this until all other things are done.
2. Omitting char filters is not intuitive.
I think this patch is not complete without support for the charfilters, because
users would expect whole analysis steps are shown in this panel. Maybe we can
show the results for char filters along with those for tokenizer/tokenfilters
by laying out the sub-panels vertically, not horizontally? (I have not yet
checked the details. Just an idea.)
Vertical layout may be also good when you add many filters like this:
!Screenshot from 2019-05-06 13-45-40.png|width=724,height=212!
In this case, I added a char filter and four token filters.
!Screenshot from 2019-05-06 13-46-16.png|width=362,height=216!
3. "Test Analyzer Step by Step" button is visible when a "Preset" analyzer is
selected.
The button does not make sense with preset analyzers, because there is always
only one step and the result is identical with "Test Analyzer".
I think this button should not be visible (or at least disabled) when "Preset"
is selected.
4. "Test Analyzer Step by Step" could be a checkbox, not a button.
To me, this functionality looks like an option to change "Test Analyzer"
behaviour. So I'd use a checkbox (labeled "step-by-step", for example) to
switch the result panel. Do you have thoughts about this?
And, I just wanted to add comments about the restriction:
{quote}Current patch is only show each tokenizer/filters result independently,
so the result doesn't show deletion/separation by next filter, e.g. "library"
by WordDelimiterFilter is different position between other output.
{quote}
Except the support for charfilters as I noted above, it seems to be fine to me.
This can be done by another issue (in the future.)
I have not yet checked the code... will do soon.
> Enhanced UI for CustomAnalyzer : show analysis steps
> ----------------------------------------------------
>
> Key: LUCENE-8793
> URL: https://issues.apache.org/jira/browse/LUCENE-8793
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/luke
> Reporter: Jun Ohtani
> Priority: Minor
> Attachments: LUCENE-8793.patch, Screen Shot 2019-05-06 at
> 10.00.57.png, Screenshot from 2019-05-06 13-45-40.png, Screenshot from
> 2019-05-06 13-46-16.png
>
>
> This is a migrated issue from previous Luke project in GitHub:
> [https://github.com/DmitryKey/luke/issues/134]
>
> For on-the-fly inspection / debugging, it is desirable to show the more
> detailed step by step information in the Custom Analyzer UI.
> This will be just like Solr's Analysis screen,
> [https://lucene.apache.org/solr/guide/7_5/analysis-screen.html]
> or Elasticsearch's {{_analyze}} API and Kibana's Analyzer UI.
> [https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-analyze.html]
> [https://github.com/johtani/analyze-api-ui-plugin]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
