[ https://issues.apache.org/jira/browse/LUCENE-8793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837742#comment-16837742 ]
Tomoko Uchida commented on LUCENE-8793: --------------------------------------- Hi [~jun_o], thanks for updating the patch. By the way I think you should update your old patch (by uploading the patch file named "LUCENE-8793.patch"), not add a new one. See: [https://wiki.apache.org/solr/HowToContribute#JIRA_tips_.28our_issue.2Fbug_tracker.29] The layout looks fine to me. I may adjust this a little before merging it to Lucene's master branch. I saw this error when double-clicking a term (cell) in the tokenizer/token filter table. {code} [2019-05-11T11:52:10,640] ERROR (ExceptionHandler.java:39) - Index -1 out of bounds for length 5 java.lang.IndexOutOfBoundsException: Index -1 out of bounds for length 5 at jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64) ~[?:?] at jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70) ~[?:?] at jdk.internal.util.Preconditions.checkIndex(Preconditions.java:248) ~[?:?] at java.util.Objects.checkIndex(Objects.java:372) ~[?:?] at java.util.ArrayList.get(ArrayList.java:458) ~[?:?] at org.apache.lucene.luke.app.desktop.components.fragments.analysis.StepByStepAnalyzeResultPanelProvider.showAttributeValues(StepByStepAnalyzeResultPanelProvider.java:154) ~[java/:?] at org.apache.lucene.luke.app.desktop.components.fragments.analysis.StepByStepAnalyzeResultPanelProvider$ListenerFunctions.showAttributeValues(StepByStepAnalyzeResultPanelProvider.java:180) ~[java/:?] at org.apache.lucene.luke.app.desktop.components.fragments.analysis.StepByStepAnalyzeResultPanelProvider$1.mouseClicked(StepByStepAnalyzeResultPanelProvider.java:92) ~[java/:?] at java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:278) ~[?:?] {code} When you double-click the cell, a dialog should pop up to show all token attributes. And one more small request: I'd like to locate "Step by Step" button just next to (or under) the "Test Analyzer" button. Can you please change this? > Enhanced UI for CustomAnalyzer : show analysis steps > ---------------------------------------------------- > > Key: LUCENE-8793 > URL: https://issues.apache.org/jira/browse/LUCENE-8793 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/luke > Reporter: Jun Ohtani > Priority: Minor > Attachments: LUCENE-8793-2.patch, LUCENE-8793.patch, Screen Shot > 2019-05-06 at 10.00.57.png, Screen Shot 2019-05-07 at 1.40.47.png, Screenshot > from 2019-05-06 13-45-40.png, Screenshot from 2019-05-06 13-46-16.png > > > This is a migrated issue from previous Luke project in GitHub: > [https://github.com/DmitryKey/luke/issues/134] > > For on-the-fly inspection / debugging, it is desirable to show the more > detailed step by step information in the Custom Analyzer UI. > This will be just like Solr's Analysis screen, > [https://lucene.apache.org/solr/guide/7_5/analysis-screen.html] > or Elasticsearch's {{_analyze}} API and Kibana's Analyzer UI. > [https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-analyze.html] > [https://github.com/johtani/analyze-api-ui-plugin] -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org