[ https://issues.apache.org/jira/browse/LUCENE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833621#comment-16833621 ]
Jim Ferenczi commented on LUCENE-7840: -------------------------------------- Note that the logic to remove SHOULD clauses is already implemented when we build the Scorer: https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/search/BooleanWeight.java#L391 Moving the logic to rewriteNoScoring makes sense to me but this won't optimize anything since the removal is already in place. > BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least > 1 MUST/FILTER clause and 0==minShouldMatch > ----------------------------------------------------------------------------------------------------------------------- > > Key: LUCENE-7840 > URL: https://issues.apache.org/jira/browse/LUCENE-7840 > Project: Lucene - Core > Issue Type: Task > Reporter: Hoss Man > Priority: Major > > I haven't thought this through completely, let alone write up a patch / test > case, but IIUC... > We should be able to optimize {{ BooleanQuery rewriteNoScoring() }} so that > (after converting MUST clauses to FILTER clauses) we can check for the common > case of {{0==getMinimumNumberShouldMatch()}} and throw away any SHOULD > clauses as long as there is is at least one FILTER clause. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org