[
https://issues.apache.org/jira/browse/LUCENE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834778#comment-16834778
]
Simon Willnauer commented on LUCENE-7840:
-----------------------------------------
I think there are some style issues in this patch like here were _else_ shoud
be on the prev line:
{code:java}
+ }
+ }
+ else {
+ newQuery.add(clause);
+ }
{code}
the other question is if we should use a switch instead of if / else? Otherwise
it's looking fine
> BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least
> 1 MUST/FILTER clause and 0==minShouldMatch
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-7840
> URL: https://issues.apache.org/jira/browse/LUCENE-7840
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Hoss Man
> Priority: Major
> Attachments: LUCENE-7840.patch, LUCENE-7840.patch
>
>
> I haven't thought this through completely, let alone write up a patch / test
> case, but IIUC...
> We should be able to optimize {{ BooleanQuery rewriteNoScoring() }} so that
> (after converting MUST clauses to FILTER clauses) we can check for the common
> case of {{0==getMinimumNumberShouldMatch()}} and throw away any SHOULD
> clauses as long as there is is at least one FILTER clause.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
