[ https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840424#comment-16840424 ]
David Smiley commented on SOLR-13331: ------------------------------------- Jason said: bq. This seems like a pretty fundamental abstraction that BAUCS breaks. I get that it saves us some object creation and brings some other efficiencies, but I question whether it's worth it at the current cost. +1 I couldn't of said it better myself. Very concerning. Also underscores the need for code reviews by implication; SOLR-12992 had no review but it touches important stuff. CC [~noble.paul] > Atomic Update Multivalue remove does not work > --------------------------------------------- > > Key: SOLR-13331 > URL: https://issues.apache.org/jira/browse/SOLR-13331 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: UpdateRequestProcessors > Affects Versions: 7.7, 7.7.1, 8.0 > Environment: Standalone Solr Server > Reporter: Thomas Wöckinger > Assignee: Jason Gerlowski > Priority: Critical > Labels: patch, pull-request-available, ready-to-commit, test > Fix For: 7.7.2, 8.1, master (9.0) > > Attachments: Fix-SOLR13331-Add-toNativeType-implementations.patch, > SOLR-13331.patch > > Time Spent: 20m > Remaining Estimate: 0h > > When using JavaBinCodec the values of collections are of type > ByteArrayUtf8CharSequence, existing field values are Strings so the remove > Operation does not have any effect. > The relevant code is located in class AtomicUpdateDocumentMerger method > doRemove. > The method parameter fieldVal contains the collection values of type > ByteArrayUtf8CharSequence, the variable original contains the collection of > Strings -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org