[ 
https://issues.apache.org/jira/browse/SOLR-2585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096072#comment-13096072
 ] 

Robert Muir commented on SOLR-2585:
-----------------------------------

{quote}
That is, if a user enters one or more words that have docFrequency > 0, but 
nevertheless are misspelled, then no suggestions are offered.
{quote}

Well this isn't exactly true: it depends on how you set 'onlyMorePopular'.

{quote}
This change allows us to offer any term within the specified maximum edit 
distance as a Suggestion, regardless of the original term's frequency in the 
inde
{quote}

Right, I think I see what you are asking for here: you want suggestions for the 
term always regardless of whether they are more popular than the original term 
or not? I'm just having trouble understanding this, because in general 
suggesting terms with a lower docfreq than the original term doesn't sound like 
it would work well...

But, if we want to do it, can we split this issue up? there are a lot of 
changes mixed in the patch:
* the directspellchecker behaves the same way as the ordinary spellchecker 
here, with this logic:
{noformat}
      if (!morePopular && freq > 0) {
        return new String[] { word };
      }
{noformat}
* if we want to add a third "mode", I think we should add this to the ordinary 
spellchecker too, instead of bypassing this logic by passing a null reader to 
it, I think this isn't very intuitive!


> Context-Sensitive Spelling Suggestions & Collations
> ---------------------------------------------------
>
>                 Key: SOLR-2585
>                 URL: https://issues.apache.org/jira/browse/SOLR-2585
>             Project: Solr
>          Issue Type: Improvement
>          Components: spellchecker
>    Affects Versions: 4.0
>            Reporter: James Dyer
>            Priority: Minor
>         Attachments: SOLR-2585.patch, SOLR-2585.patch
>
>
> Solr currently cannot offer what I'm calling here a "context-sensitive" 
> spelling suggestion.  That is, if a user enters one or more words that have 
> docFrequency > 0, but nevertheless are misspelled, then no suggestions are 
> offered.  Currently, Solr will always consider a word "correctly spelled" if 
> it is in the index and/or dictionary, regardless of context.  This issue & 
> patch add support for context-sensitive spelling suggestions. 
> See SpellCheckCollatorTest.testContextSensitiveCollate() for a the typical 
> use case for this functionality.  This tests both using 
> IndexBasedSepllChecker and DirectSolrSpellChecker. 
> Two new Spelling Parameters were added:
>   - spellcheck.alternativeTermCount - The count of suggestions to return for 
> each query term existing in the index and/or dictionary.  Presumably, users 
> will want fewer suggestions for words with docFrequency>0.  Also setting this 
> value turns "on" context-sensitive spell suggestions. 
>   - spellcheck.maxResultsForSuggest - The maximum number of hits the request 
> can return in order to both generate spelling suggestions and set the 
> "correctlySpelled" element to "false".  For example, if this is set to 5 and 
> the user's query returns 5 or fewer results, the spellchecker will report 
> "correctlySpelled=false" and also offer suggestions (and collations if 
> requested).  Setting this greater than zero is useful for creating 
> "did-you-mean" suggestions for queries that return a low number of hits.
> I have also included a test using shards.  See additions to 
> DistributedSpellCheckComponentTest. 
> In Lucene, SpellChecker.java can already support this functionality (by 
> passing a null IndexReader and field-name).  The DirectSpellChecker, however, 
> needs a minor enhancement.  This gives the option to allow DirectSpellChecker 
> to return suggestions for all query terms regardless of frequency.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to