CaoManhDat commented on a change in pull request #685: SOLR-13434: OpenTracing
support for Solr
URL: https://github.com/apache/lucene-solr/pull/685#discussion_r288036673
##########
File path: solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java
##########
@@ -379,6 +397,23 @@ public void doFilter(ServletRequest _request,
ServletResponse _response, FilterC
}
}
+ SpanContext parentSpan = GlobalTracer.extract(request);
Review comment:
I don't think we should do that, since introducing another Filter require
changes and several places (web.xml).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
