CaoManhDat commented on a change in pull request #685: SOLR-13434: OpenTracing 
support for Solr
URL: https://github.com/apache/lucene-solr/pull/685#discussion_r288469177
 
 

 ##########
 File path: solr/contrib/jaegertracer-configurator/README.txt
 ##########
 @@ -0,0 +1,30 @@
+Welcome to Apache Solr Prometheus Exporter
+========
+
+Apache Solr Jaeger Tracer Configurator (solr-jaeger-tracer) provides a way for 
you to expose Solr's tracing to Jaeger.
+
+# Setup Jaeger Tracer Configurator
+
+Note that all library of solr-jaeger-tracer must be included in the classpath 
of all nodes then Jaeger tracer can be setup in `solr.xml` like this:
+
+```
+<tracerConfig name="tracerConfig" 
class="org.apache.solr.jaeger.JaegerTracerConfigurator">
 
 Review comment:
   I quite doubt about sample rate per collections. This kinda complex and 
requires more careful thoughts about it. Since there are APIs in Solr that does 
not tie specificly to any collection (Collections API, autoscaling, streaming 
expressions, etc).
   It should be handled in another issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to