[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850635#comment-16850635 ]
Adrien Grand commented on LUCENE-8811: -------------------------------------- I'm wondering whether IndexSearcher could return "this" in getSubVisitor (including for MUST_NOT) and then we would count the number of calls to visitLeaf? This way it would work for DisjunctionMaxQuery and custom queries as well. I like that it removes ways to by-pass the maximum clause count by splitting boolean queries into multiple sub boolean queries. Wondering what others think about it [~thetaphiā€¨] [~rcmuir] [~mikemccand]? > Add maximum clause count check to IndexSearcher rather than BooleanQuery > ------------------------------------------------------------------------ > > Key: LUCENE-8811 > URL: https://issues.apache.org/jira/browse/LUCENE-8811 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Adrien Grand > Priority: Minor > Attachments: LUCENE-8811.patch > > > Currently we only check whether boolean queries have too many clauses. > However there are other ways that queries may have too many clauses, for > instance if you have boolean queries that have themselves inner boolean > queries. > Could we use the new Query visitor API to move this check from BooleanQuery > to IndexSearcher in order to make this check more consistent across queries? > See for instance LUCENE-8810 where a rewrite rule caused the maximum clause > count to be hit even though the total number of leaf queries remained the > same. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org