[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858623#comment-16858623
]
Atri Sharma commented on LUCENE-8811:
-------------------------------------
[~romseygeek] Ok, I misinterpreted your previous comment to do the actual
refactor of max clauses count from BooleanQuery to IndexSearcher in a follow up
patch due to the different constructs it touches, apologies.
I wanted to confirm our line of thought here: max clauses count would be a part
of IndexSearcher now (as would be TooManyClauses exception, as done in previous
iteration). However, IndexSearcher will not have the ability to have per
searcher custom values for the maxclauses limit, and the new QueryVisitor will
still use the static value. The custom per searcher value will be done in a
separate patch.
Would that be correct? I wanted to double check before posting another
iteration, thanks.
> Add maximum clause count check to IndexSearcher rather than BooleanQuery
> ------------------------------------------------------------------------
>
> Key: LUCENE-8811
> URL: https://issues.apache.org/jira/browse/LUCENE-8811
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-8811.patch, LUCENE-8811.patch, LUCENE-8811.patch,
> LUCENE-8811.patch
>
>
> Currently we only check whether boolean queries have too many clauses.
> However there are other ways that queries may have too many clauses, for
> instance if you have boolean queries that have themselves inner boolean
> queries.
> Could we use the new Query visitor API to move this check from BooleanQuery
> to IndexSearcher in order to make this check more consistent across queries?
> See for instance LUCENE-8810 where a rewrite rule caused the maximum clause
> count to be hit even though the total number of leaf queries remained the
> same.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
