[
https://issues.apache.org/jira/browse/LUCENE-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098580#comment-13098580
]
Chris Male commented on LUCENE-3396:
------------------------------------
Hmmm, I agree that we should change it to void. If the source cannot be reset,
it should throw an Exception. We need to be able to rely on the fact that we
are using reusable components.
I'll update the patch.
> Make TokenStream Reuse Mandatory for Analyzers
> ----------------------------------------------
>
> Key: LUCENE-3396
> URL: https://issues.apache.org/jira/browse/LUCENE-3396
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/analysis
> Reporter: Chris Male
> Attachments: LUCENE-3396-rab.patch, LUCENE-3396-rab.patch,
> LUCENE-3396-rab.patch, LUCENE-3396-rab.patch, LUCENE-3396-rab.patch
>
>
> In LUCENE-2309 it became clear that we'd benefit a lot from Analyzer having
> to return reusable TokenStreams. This is a big chunk of work, but its time
> to bite the bullet.
> I plan to attack this in the following way:
> - Collapse the logic of ReusableAnalyzerBase into Analyzer
> - Add a ReuseStrategy abstraction to Analyzer which controls whether the
> TokenStreamComponents are reused globally (as they are today) or per-field.
> - Convert all Analyzers over to using TokenStreamComponents. I've already
> seen that some of the TokenStreams created in tests need some work to be
> reusable (even if they aren't reused).
> - Remove Analyzer.reusableTokenStream and convert everything over to using
> .tokenStream (which will now be returning reusable TokenStreams).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
