[ 
https://issues.apache.org/jira/browse/LUCENE-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Male updated LUCENE-3396:
-------------------------------

    Attachment: LUCENE-3396-remaining-merging.patch

Patch which finalizes the remaining Analyzer changes and merges 
ReusableAnalyzerBase and Analyzer together.  

Command for the patch:

{code}
# Keep old Analyzer.java temporarily for comparison
svn rename lucene/src/java/org/apache/lucene/analysis/Analyzer.java 
lucene/src/java/org/apache/lucene/analysis/Analyzer.java.old
svn rename lucene/src/java/org/apache/lucene/analysis/ReusableAnalyzerBase.java 
lucene/src/java/org/apache/lucene/analysis/Analyzer.java
{code}

I have updated the javadocs to reflect the merging and have removed the 
assertFinal() assertion since tokenStream() and reusableTokenStream() are 
always final now.

All tests pass and javadocs build.  I am looking to commit this soon (with a 
MIGRATE.txt entry).

> Make TokenStream Reuse Mandatory for Analyzers
> ----------------------------------------------
>
>                 Key: LUCENE-3396
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3396
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/analysis
>            Reporter: Chris Male
>         Attachments: LUCENE-3396-forgotten.patch, LUCENE-3396-rab.patch, 
> LUCENE-3396-rab.patch, LUCENE-3396-rab.patch, LUCENE-3396-rab.patch, 
> LUCENE-3396-rab.patch, LUCENE-3396-rab.patch, LUCENE-3396-rab.patch, 
> LUCENE-3396-remaining-analyzers.patch, LUCENE-3396-remaining-merging.patch
>
>
> In LUCENE-2309 it became clear that we'd benefit a lot from Analyzer having 
> to return reusable TokenStreams.  This is a big chunk of work, but its time 
> to bite the bullet.
> I plan to attack this in the following way:
> - Collapse the logic of ReusableAnalyzerBase into Analyzer
> - Add a ReuseStrategy abstraction to Analyzer which controls whether the 
> TokenStreamComponents are reused globally (as they are today) or per-field.
> - Convert all Analyzers over to using TokenStreamComponents.  I've already 
> seen that some of the TokenStreams created in tests need some work to be 
> reusable (even if they aren't reused).
> - Remove Analyzer.reusableTokenStream and convert everything over to using 
> .tokenStream (which will now be returning reusable TokenStreams).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to