[
https://issues.apache.org/jira/browse/SOLR-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098878#comment-13098878
]
Michael McCandless commented on SOLR-2066:
------------------------------------------
The changes to modules/grouping look good...
There's a small typo in the comment ("In case groups where indexed..."
-> "In case groups were indexed..."). Also I wouldn't call this
"properly"? Ie, it's OK if the same group value appears on more than
one shard? It just means we can't compute the exact total group count
(we can compute an upper bound).
Can you update the .merge javadocs? Now it says it cannot compute
totalGroupCount; I think just change that to say that it'll produce
the sum of the total group counts, which is an upper bound on the true
value? And this will be exact if you know the groups are orthogonal
across shards?
Maybe, for better readability, change this:
{noformat}
if (groupValue != null ? !groupValue.equals(that.groupValue) :
that.groupValue != null) return false;
{noformat}
to this:
{noformat}
if (groupValue == null) {
if (that.groupValue != null) {
return false;
}
} else if (!groupValue.equals(other.groupValue)) {
return false;
}
{noformat}
?
> Search Grouping: support distributed search
> -------------------------------------------
>
> Key: SOLR-2066
> URL: https://issues.apache.org/jira/browse/SOLR-2066
> Project: Solr
> Issue Type: Sub-task
> Reporter: Yonik Seeley
> Fix For: 3.4, 4.0
>
> Attachments: SOLR-2066.patch, SOLR-2066.patch, SOLR-2066.patch,
> SOLR-2066.patch, SOLR-2066.patch, SOLR-2066.patch, SOLR-2066.patch
>
>
> Support distributed field collapsing / search grouping.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
