[
https://issues.apache.org/jira/browse/SOLR-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099153#comment-13099153
]
Martijn van Groningen commented on SOLR-2066:
---------------------------------------------
Thanks for the review! I'll update the patch.
The SearchGroup#equals method was generated, so that is why it isn't very
readable.
bq. And this will be exact if you know the groups are orthogonal across shards?
Yes, if all the documents of a group reside on the same shard, the groupCount
will be correct.
bq. I think just change that to say that it'll produce the sum of the total
group counts, which is an upper bound on the true value?
If documents of a group do reside on more than one shard then the count will
always be higher then it would be if all documents of a group stay on one
shard. So it is an upper bound.
> Search Grouping: support distributed search
> -------------------------------------------
>
> Key: SOLR-2066
> URL: https://issues.apache.org/jira/browse/SOLR-2066
> Project: Solr
> Issue Type: Sub-task
> Reporter: Yonik Seeley
> Fix For: 3.4, 4.0
>
> Attachments: SOLR-2066.patch, SOLR-2066.patch, SOLR-2066.patch,
> SOLR-2066.patch, SOLR-2066.patch, SOLR-2066.patch, SOLR-2066.patch
>
>
> Support distributed field collapsing / search grouping.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
