[
https://issues.apache.org/jira/browse/SOLR-13577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875163#comment-16875163
]
Hoss Man commented on SOLR-13577:
---------------------------------
Mikhail: 2 thoughts...
# recent failures seem to only happen on windows, so don't rule out the
possibility that your fixes have actual uncovered an real bug in how
replication works/fails on windows in some situations
# the problem may simply be thread contention ... IIUC the test is trying to
verify that *after* the master shuts down, *then* the slave should poll and see
the master is down, and *then* we should be able to ask the slave for details
and see that failure cont ... but nothing in the test "waits" to ensure the
master is actually shutdown – by the time we've used up all our retires the
master may still be up, let alone giving the slave enough time to poll the
master.
i would suggest adding logic similar to what's in
{{MiniSolrCloudCluster.waitForJettyToStop()}} to the test to verify the master
is down *before* starting the retry loop that attempts to fetch details from
the slave.
> TestReplicationHandler.doTestIndexFetchOnMasterRestart failures
> ---------------------------------------------------------------
>
> Key: SOLR-13577
> URL: https://issues.apache.org/jira/browse/SOLR-13577
> Project: Solr
> Issue Type: Test
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Mikhail Khludnev
> Assignee: Mikhail Khludnev
> Priority: Major
> Attachments: 8016-consoleText.zip, SOLR-13577.patch,
> SOLR-13577.patch, SOLR-13577.patch, screenshot-1.png, still failed on Windows
> consoleText.zip
>
>
> It's seems like clear test failures. Failed 6 times in a row at lines 682, 684
> {quote}
> org.apache.solr.handler.TestReplicationHandler.doTestIndexFetchOnMasterRestart
> Failing for the past 1 build (Since Failed#8011 )
> Took 6 sec.
> Error Message
> null
> Stacktrace
> java.lang.NumberFormatException: null
> at
> __randomizedtesting.SeedInfo.seed([6AB4ECC957E5CCA2:B243282DFC3E0EFE]:0)
> at java.base/java.lang.Integer.parseInt(Integer.java:614)
> at java.base/java.lang.Integer.parseInt(Integer.java:770)
> at
> org.apache.solr.handler.TestReplicationHandler.doTestIndexFetchOnMasterRestart(TestReplicationHandler.java:682)
> org.apache.solr.handler.TestReplicationHandler.doTestIndexFetchOnMasterRestart
> Failing for the past 3 builds (Since Failed#8011 )
> Took 7.5 sec.
> Stacktrace
> java.lang.AssertionError
> at
> __randomizedtesting.SeedInfo.seed([E88092B4017D2D3D:30775650AAA6EF61]:0)
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at
> org.apache.solr.handler.TestReplicationHandler.doTestIndexFetchOnMasterRestart(TestReplicationHandler.java:684)
> {quote}
> !screenshot-1.png!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
