[
https://issues.apache.org/jira/browse/SOLR-13577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875256#comment-16875256
]
Hoss Man commented on SOLR-13577:
---------------------------------
well... i think it would be a huge mistake to remove
{{waitForJettyToStop(JettySolrRunner)}} from {{MiniSolrCloudCluster}} – not
only does it affect a lot of tests unneccesarily, but it breaks backcompat for
end users that have existing tests using {{MiniSolrCloudCluster}}.
If you really want to add {{waitForJettyToStop()}} to {{JettySolrRunner}}, just
make the existing {{waitForJettyToStop(JettySolrRunner)}} a thin wrapper around
it ... but if it were me i'd kep the changes dead simple and just use
something like this in TestReplicationHandler...
{code:java}
final TimeOut waitForLeaderToShutdown = new TimeOut(300, TimeUnit.SECONDS,
TimeSource.NANO_TIME);
waitForLeaderToShutdown.waitFor
("Gave up after waiting an obscene amount of time for leader to shut down",
() -> { masterJetty.isStopped() })
{code}
> TestReplicationHandler.doTestIndexFetchOnMasterRestart failures
> ---------------------------------------------------------------
>
> Key: SOLR-13577
> URL: https://issues.apache.org/jira/browse/SOLR-13577
> Project: Solr
> Issue Type: Test
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Mikhail Khludnev
> Assignee: Mikhail Khludnev
> Priority: Major
> Attachments: 8016-consoleText.zip, SOLR-13577.patch,
> SOLR-13577.patch, SOLR-13577.patch, SOLR-13577.patch, screenshot-1.png, still
> failed on Windows consoleText.zip
>
>
> It's seems like clear test failures. Failed 6 times in a row at lines 682, 684
> {quote}
> org.apache.solr.handler.TestReplicationHandler.doTestIndexFetchOnMasterRestart
> Failing for the past 1 build (Since Failed#8011 )
> Took 6 sec.
> Error Message
> null
> Stacktrace
> java.lang.NumberFormatException: null
> at
> __randomizedtesting.SeedInfo.seed([6AB4ECC957E5CCA2:B243282DFC3E0EFE]:0)
> at java.base/java.lang.Integer.parseInt(Integer.java:614)
> at java.base/java.lang.Integer.parseInt(Integer.java:770)
> at
> org.apache.solr.handler.TestReplicationHandler.doTestIndexFetchOnMasterRestart(TestReplicationHandler.java:682)
> org.apache.solr.handler.TestReplicationHandler.doTestIndexFetchOnMasterRestart
> Failing for the past 3 builds (Since Failed#8011 )
> Took 7.5 sec.
> Stacktrace
> java.lang.AssertionError
> at
> __randomizedtesting.SeedInfo.seed([E88092B4017D2D3D:30775650AAA6EF61]:0)
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at
> org.apache.solr.handler.TestReplicationHandler.doTestIndexFetchOnMasterRestart(TestReplicationHandler.java:684)
> {quote}
> !screenshot-1.png!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
