magibney commented on a change in pull request #677: SOLR-13257: support for stable replica routing preferences URL: https://github.com/apache/lucene-solr/pull/677#discussion_r302354143
########## File path: solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java ########## @@ -197,6 +200,60 @@ private static boolean getDisableShardsWhitelist() { return Boolean.getBoolean(INIT_SOLR_DISABLE_SHARDS_WHITELIST); } + private static NamedList<?> getNamedList(Object val) { + if (val instanceof NamedList) { + return (NamedList<?>)val; + } else { + throw new IllegalArgumentException("Invalid config for replicaRouting: " + val); Review comment: Agreed, will push update shortly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org