dsmiley commented on a change in pull request #780: SOLR-11866: Support
efficient subset matching in query elevation rules
URL: https://github.com/apache/lucene-solr/pull/780#discussion_r303611139
##########
File path:
solr/core/src/test/org/apache/solr/handler/component/QueryElevationComponentTest.java
##########
@@ -391,13 +394,13 @@ public void testInterface() throws Exception {
req.close();
// Make sure the boosts loaded properly
- assertEquals(7, elevationProvider.size());
+ assertEquals(11, elevationProvider.size());
assertEquals(1,
elevationProvider.getElevationForQuery("XXXX").elevatedIds.size());
assertEquals(2,
elevationProvider.getElevationForQuery("YYYY").elevatedIds.size());
assertEquals(3,
elevationProvider.getElevationForQuery("ZZZZ").elevatedIds.size());
- assertEquals(null, elevationProvider.getElevationForQuery("xxxx"));
- assertEquals(null, elevationProvider.getElevationForQuery("yyyy"));
- assertEquals(null, elevationProvider.getElevationForQuery("zzzz"));
+ assertNull(elevationProvider.getElevationForQuery("xxxx"));
+ assertNull(null, elevationProvider.getElevationForQuery("yyyy"));
Review comment:
not strictly your doing but lets remove the null message
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
