dsmiley commented on a change in pull request #780: SOLR-11866: Support
efficient subset matching in query elevation rules
URL: https://github.com/apache/lucene-solr/pull/780#discussion_r303722666
##########
File path:
solr/core/src/java/org/apache/solr/handler/component/QueryElevationComponent.java
##########
@@ -425,10 +429,10 @@ protected ElevationProvider
loadElevationProvider(XmlConfigFile config) throws I
previousElevationBuilder.merge(elevationBuilder);
}
}
- return createElevationProvider(queryAnalyzer, elevationBuilderMap);
+ return createElevationProvider(elevationBuilderMap);
Review comment:
Just checking: you did this because queryAnalyzer is in scope to caller so
no need to pass as param?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
