uschindler commented on a change in pull request #758: LUCENE-8833: Add a
#load() method to IndexInput to allow preloading file content into physical
memory
URL: https://github.com/apache/lucene-solr/pull/758#discussion_r313962652
##########
File path: lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java
##########
@@ -202,24 +201,6 @@ public boolean getUseUnmap() {
return useUnmapHack;
}
- /**
- * Set to {@code true} to ask mapped pages to be loaded
- * into physical memory on init. The behavior is best-effort
- * and operating system dependent.
- * @see MappedByteBuffer#load
- */
- public void setPreload(boolean preload) {
Review comment:
I tend to keep the "always preload method", just deprecate it for now. I
know many people that use this globally. It has the side-effect of setting
madvise to "WILL_NEED" for the whole buffer (in addition to load it), so it is
a bit more sticky as it's marked to the kernel as "i will need it soon".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
