uschindler commented on a change in pull request #758: LUCENE-8833: Add a
#load() method to IndexInput to allow preloading file content into physical
memory
URL: https://github.com/apache/lucene-solr/pull/758#discussion_r313964577
##########
File path: solr/core/src/java/org/apache/solr/core/MMapDirectoryFactory.java
##########
@@ -61,13 +64,23 @@ public void init(NamedList args) {
@Override
protected Directory create(String path, LockFactory lockFactory, DirContext
dirContext) throws IOException {
// we pass NoLockFactory, because the real lock factory is set later by
injectLockFactory:
- MMapDirectory mapDirectory = new MMapDirectory(new File(path).toPath(),
lockFactory, maxChunk);
+ final boolean preloadIndexInput = this.preload;
+ MMapDirectory mapDirectory = new MMapDirectory(new File(path).toPath(),
lockFactory, maxChunk) {
Review comment:
I know you don't care about Solr, but this seems to change the system
information to show a strange class name instead of the current MMapDirectory
output in the system info page of Solr. I have to investigate this, but as said
before, I tend to not remove the setPreload() method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
