[ 
https://issues.apache.org/jira/browse/SOLR-13452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913658#comment-16913658
 ] 

Mark Miller commented on SOLR-13452:
------------------------------------

[~ivera], thanks, good catches - one of the hard parts of this forking off long 
ago when Dat first started work, is keeping up to date on newer additions. I'll 
stub those out this weekend.

 

bq.  And a question: which is the gradle command similar to ant precommit?

Currently, this remains to be seen. Before we merge into master, I'll try and 
make a detailed list of things we still need to resolve.

Right now, many of the items that where part of precommit are now tasks that 
the check task depends on. This means many of those checks are now run during 
build, and in parallel across modules. We have to see how good all those checks 
scale across older hardware.

A precommit task that is not finished right now is the check javadocs for 
missing links check - I have an early stub for creating javadoc across all 
modules. but it's currently commented out.

My feeling was, if we can get all the checks other than something like the 
javadoc missing links, maybe precommit should go away, checks are run as part 
of the normal build, and we count on jenkins to catch missing javadoc links if 
that task must remain non parallel and very slow.

If we have to retain more than one long running important check task though, 
perhaps precommit stays.

Right now though, the currently implemented and uncommented checks are part of 
the check task and not something you normally run independently.

> Update the lucene-solr build from Ivy+Ant+Maven (shadow build) to Gradle.
> -------------------------------------------------------------------------
>
>                 Key: SOLR-13452
>                 URL: https://issues.apache.org/jira/browse/SOLR-13452
>             Project: Solr
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Major
>             Fix For: master (9.0)
>
>         Attachments: gradle-build.pdf
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> I took some things from the great work that Dat did in 
> [https://github.com/apache/lucene-solr/tree/jira/gradle] and took the ball a 
> little further.
>  
> When working with gradle in sub modules directly, I recommend 
> [https://github.com/dougborg/gdub]
> This gradle branch uses the following plugin for version locking, version 
> configuration and version consistency across modules: 
> [https://github.com/palantir/gradle-consistent-versions]
>  
> https://github.com/apache/lucene-solr/tree/jira/SOLR-13452_gradle_5



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to