cpoerschke commented on issue #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#issuecomment-528843185 Thanks @diegoceccarelli for the pushes and the documentation additions too! > ... precommit is failing at the moment due to "Rat problems" ... Interesting, strange, seemed to be fine for me locally. I've started looking at the tests and https://github.com/cpoerschke/lucene-solr/commits/github-bloomberg-SOLR-11831-cpoerschke-12 shares some work-in-progress scribbles. A `variantQuery` helper method was recently added in the `TestDistributedGrouping` class, I wonder if it and/or additional comments or formatting could help clarify the intent and rationale behind some of the test queries. Will also annotate specific observations (and spoiler alert) one unexpected test failure mystery.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org