cpoerschke commented on issue #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#issuecomment-528868837 > ... Will also annotate specific observations (and spoiler alert) one unexpected test failure mystery. ... Alright, annotations are complete, let me know what you think? And here's the test failure mystery i.e. for ``` query("q", "{!func}id_i1", "group.skip.second.step", true, "fl", "id," + i1, "group", "true", "group.field", i1, "group.limit", 1, "sort", i1+" desc"); ``` it mostly gives this error ``` [junit4] 2> 15996 ERROR (TEST-TestDistributedGrouping.test-seed#[722F68DB7C831C15]) [ ] o.a.s.BaseDis tributedSearchTestCase Mismatched responses: [junit4] 2> {responseHeader={status=0,QTime=3},grouped={a_i1={matches=272,groups=[{groupValue=99999,docli st={numFound=1,start=0,maxScore=-1.0,docs=[SolrDocument{a_i1=99999, id=1000}]}}, {groupValue=9999,doclist={num Found=1,start=0,maxScore=-1.0,docs=[SolrDocument{a_i1=9999, id=500}]}}, {groupValue=4321,doclist={numFound=1,s tart=0,maxScore=-1.0,docs=[SolrDocument{id=10, a_i1=4321}]}}, {groupValue=876,doclist={numFound=1,start=0,maxS core=-1.0,docs=[SolrDocument{id=8, a_i1=876}]}}, {groupValue=500,doclist={numFound=1,start=0,maxScore=-1.0,doc s=[SolrDocument{id=5, a_i1=500}]}}, {groupValue=379,doclist={numFound=1,start=0,maxScore=-1.0,docs=[SolrDocume nt{id=12, a_i1=379}]}}, {groupValue=233,doclist={numFound=1,start=0,maxScore=-1.0,docs=[SolrDocument{id=23, a_ i1=233}]}}, {groupValue=232,doclist={numFound=1,start=0,maxScore=-1.0,docs=[SolrDocument{id=19, a_i1=232}]}}, {groupValue=123,doclist={numFound=1,start=0,maxScore=-1.0,docs=[SolrDocument{id=7, a_i1=123}]}}, {groupValue=1 00,doclist={numFound=1,start=0,maxScore=-1.0,docs=[SolrDocument{id=1, a_i1=100}]}}]}}} [junit4] 2> {responseHeader={status=0,QTime=0},grouped={a_i1={matches=272,groups=[{groupValue=99999,docli st={numFound=100,start=0,docs=[SolrDocument{a_i1=99999, id=1000}]}}, {groupValue=9999,doclist={numFound=100,st art=0,docs=[SolrDocument{a_i1=9999, id=500}]}}, {groupValue=4321,doclist={numFound=1,start=0,docs=[SolrDocumen t{id=10, a_i1=4321}]}}, {groupValue=876,doclist={numFound=1,start=0,docs=[SolrDocument{id=8, a_i1=876}]}}, {gr oupValue=500,doclist={numFound=1,start=0,docs=[SolrDocument{id=5, a_i1=500}]}}, {groupValue=379,doclist={numFo und=1,start=0,docs=[SolrDocument{id=12, a_i1=379}]}}, {groupValue=233,doclist={numFound=1,start=0,docs=[SolrDo cument{id=23, a_i1=233}]}}, {groupValue=232,doclist={numFound=5,start=0,docs=[SolrDocument{id=18, a_i1=232}]}} , {groupValue=123,doclist={numFound=1,start=0,docs=[SolrDocument{id=7, a_i1=123}]}}, {groupValue=100,doclist={ numFound=1,start=0,docs=[SolrDocument{id=1, a_i1=100}]}}]}}} ... [junit4] FAILURE 14.4s | TestDistributedGrouping.test <<< [junit4] > Throwable #1: junit.framework.AssertionFailedError: .grouped[a_i1].groups[7].doclist[0][id][0 ]:19!=18 ... ``` but sometimes it succeeds (and about the documents 18 and 19 in group 232 being indexed e.g. at https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.2.0/solr/core/src/test/org/apache/solr/TestDistributedGrouping.java#L115-L144 nothing jumps out as unusual). ---- And last but not least, thank you @diegoceccarelli for continuing to work on this pull request!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
