Anshum et. al. :
It’s been a busy day, never got back to it. I’ll try to push my changes, mostly
updating the dependencies tonight.
It’s not ready to merge into master yet, there’s this problem:
ant -Dtestcase=TestKoreanTokenizer test
fails with:
java.lang.RuntimeException: Cannot find userdict.txt in test classpath!
userdict.txt gets copied when I test on the trunk branch to (at least I think
this is the corresponding one):
./lucene/build/analysis/nori/classes/test/org/apache/lucene/analysis/ko/userdict.txt
So my presumption is that the ant build takes care of this and somehow the
classpath is set to include it.
This is on a clean checkout of the current gradle_8 branch, _without_ trying to
do anything with Gradle.
I’m thrashing by trying to both update the dependencies and fix this problem at
once, so I’ll concentrate on the dependencies tonight an (hopefully) get that
pushed.
If you have time and energy to tackle the TestKoreanTokenizer bit, that’d be
great. Otherwise I may get back to it Friday or this weekend.
Thanks!
Erick
> On Nov 13, 2019, at 6:52 PM, Anshum Gupta <ans...@anshumgupta.net> wrote:
>
> Hey Erick,
>
> Any updates on this? Just checking in and though I'm not a gradle guru, I'd
> be happy to help as much as I can :)
>
> -Anshum
>
> On Tue, Nov 12, 2019 at 7:32 PM Erick Erickson <erickerick...@gmail.com>
> wrote:
> Final note before I turn in. “ant -Dtestcase=TestKoreanTokenizer” fails OOB
> on the gradle_8 branch with:
>
> java.lang.RuntimeException: Cannot find userdict.txt in test classpath!
>
> I see on master that that file is copied into
> lucene/build/analysis/nori/classes/test/org/apache/lucene/analysis/ko/userdict.txt
>
> I’ll look at it more tomorrow.
>
> After that gets fixed, and pending the bits about asciidoctorj, I think it’s
> close to ready to push to master and iterate there.
>
> Erick
>
> > On Nov 12, 2019, at 4:35 PM, Dawid Weiss <dawid.we...@gmail.com> wrote:
> >
> > Oh, sorry -- I thought you meant this line to be added to the main
> > dependencies section (not buildScript's).
> >
> > D.
> >
> > On Tue, Nov 12, 2019 at 10:14 PM Anshum Gupta <ans...@anshumgupta.net>
> > wrote:
> >>
> >> I didn't add this. This is already in the gradle_8 branch.
> >>
> >> What branch are you looking at? Don't you see this too ?
> >>
> >>
> >> On Tue, Nov 12, 2019 at 12:56 PM Dawid Weiss <dawid.we...@gmail.com> wrote:
> >>>
> >>>> Looking at the following file:
> >>>> solr/solr-ref-guide/build.gradle
> >>>>
> >>>> I see the apparently missing dependency:
> >>>
> >>> The buildscript dependency is there because, well, we use it from the
> >>> script itself.
> >>>
> >>> For the "tools" configuration classpath the dependency is not missing,
> >>> it's correct without the
> >>> version number (palantir's plugin resolves it):
> >>>
> >>> tools('org.asciidoctor:asciidoctorj')
> >>>
> >>>> dependencies {
> >>>> classpath "org.asciidoctor:asciidoctorj:1.6.0-alpha.5"
> >>>> }
> >>>
> >>> This isn't correct, don't add it. The existing config in that script
> >>> is fine (and works for me); I think Erik's problem is caused by
> >>> something else.
> >>>
> >>> D.
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> >>> For additional commands, e-mail: dev-h...@lucene.apache.org
> >>>
> >>
> >>
> >> --
> >> Anshum Gupta
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> > For additional commands, e-mail: dev-h...@lucene.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> For additional commands, e-mail: dev-h...@lucene.apache.org
>
>
>
> --
> Anshum Gupta
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
