Great, thank you Jan for the pointers and context!

The INFRA tickets you mentioned and their GitBox component labelling led me to 
discover https://issues.apache.org/jira/browse/INFRA-15296 entitled "Github 
comments not going to mailing lists" i.e. a JIRA already exists.

Christine

From: [email protected] At: 03/05/20 16:17:16To:  Christine Poerschke 
(BLOOMBERG/ LONDON ) ,  [email protected]
Subject: Re: github commit comments not(?) forwarded to list?

I think you may find the answer here :)

https://github.com/apache/infrastructure-puppet/blob/a66ec4204550ef9cbc89ef65e7cec3f35f39a07a/modules/gitbox/files/cgi-bin/issues.cgi#L358-L361

I made some contributions to that code in INFRA-19263 so I know that the 
handling of the GH callbacks is very basic…
It also is quite stupid in how it handles PR reviews, so I opened INFRA-19297 
for that.

Feel free to open a JIRA for the commit comments as well. I know INFRA is 
planning to deprecate the issues.cgi script and implement a more intelligent 
system with all callbacks being put on a queue and then processed by some 
workers, but I’m not sure where they are in that effort. Just in case you 
should feel like writing some code, you should check with them first if 
issues.cgi is going away tomorrow :)

Jan


5. mar. 2020 kl. 15:57 skrev Christine Poerschke (BLOOMBERG/ LONDON) 
<[email protected]>:
Hello everyone.

Yesterday I realised that comments on github.com/apache/lucene-solr commits are 
possible -- e.g. 
https://github.com/apache/lucene-solr/commit/def6816f48598ce8e8757239b98969b5e18b21af#diff-755a6c65165611aab0efa0a8e9ff0ac9
 -- but are not forwarded to any of our lists it seems?

Might this be
(a) by omission i.e. we never set it up
and/or
(b) by choice i.e. it was considered and deliberately not set up
and/or
(c) due to technical limitations i.e. it was/is not possible to forward
and/or
(d) some other reason(s)?

Does anyone recall? (I haven't yet dug through the github integration email 
threads past.)

Thanks,

Christine


Reply via email to