Found the bug in the bugfix :) Committed a 2-line fix to ‘index.html’, see https://github.com/apache/lucene-solr/commit/e15b02c/ and to merged to branch_8x
Ignacio, let me know if you want me to merge the fix to branch_8_5 in case of a respin. Jan > 14. apr. 2020 kl. 14:36 skrev Cassandra Targett <casstarg...@gmail.com>: > > Jan, I also see the same text you hoped to fix with SOLR-14359. > > I think I might see a clue to the problem - in your PR you updated > “angular-chosen.min.js” but the head section of index.html also calls > “chosen.jquery.min.js”. > > The problematic text in the drop downs is found in a <span> element enclosed > in an <a> element which has classes defined that are only found in > “chosen.jquery.min.js” - I suspect this file also needs to be updated in some > way. Here’s the rendered HTML: > > <a class="chosen-single chosen-default”> > <span>Select an Option</span> > <div><b></b></div> > </a> > > I agree it doesn’t warrant a respin. To be honest, I don’t even remember what > it was supposed to say, so my feeling is we could live with it until 8.6. > > Cassandra > On Apr 14, 2020, 6:13 AM -0500, Jan Høydahl <jan....@cominvent.com>, wrote: >> Ran the smoke tester ok. >> Started Solr from the downloaded package to validate the only Solr bugfix in >> this release: >> >> * SOLR-14359: Admin UI collection/core drop-downs had wrong placeholder >> text. Fixed by upgrading angular-chosen (janhoy) >> >> However, the drop-downs still show «Select an Option» as before the fix, >> with this error in JS console >> <https://code.angularjs.org/1.7.9/docs/error/$parse/syntax?p0=Selector&p1=is%20an%20unexpected%20token&p2=6&p3=Core%20Selector&p4=Selector>. >> >> Strange thing is that when re-trying on branch_8x and master the same >> happens there, across several browsers. >> Which leads me to think that the patch, as committed, had an issue all >> along. Although it worked locally when I did the merge... >> NIce if someone could check on your end and report whether you see the same. >> >> I’m not -1 the release due to the low severity of the bug. I’ll dig some >> more on master… >> >> Jan >> >>> 8. apr. 2020 kl. 12:30 skrev Ignacio Vera <iver...@gmail.com >>> <mailto:iver...@gmail.com>>: >>> >>> >>> Please vote for release candidate 1 for Lucene/Solr 8.5.1 >>> >>> The artifacts can be downloaded from: >>> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.5.1-RC1-revedb9fc409398f2c3446883f9f80595c884d245d0 >>> >>> <https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.5.1-RC1-revedb9fc409398f2c3446883f9f80595c884d245d0> >>> >>> You can run the smoke tester directly with this command: >>> >>> python3 -u dev-tools/scripts/smokeTestRelease.py \ >>> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.5.1-RC1-revedb9fc409398f2c3446883f9f80595c884d245d0 >>> >>> <https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.5.1-RC1-revedb9fc409398f2c3446883f9f80595c884d245d0> >>> >>> The vote will be open for at least 72 hours i.e. until 2020-04-15 11:00 UTC. >>> >>> [ ] +1 approve >>> [ ] +0 no opinion >>> [ ] -1 disapprove (and reason why) >>> >>> Here is my +1 >>> >>> SUCCESS! [1:02:16.691004] >>> >>
