Alan and I worked out how to do this on the PR, and the change was made without affecting the API signatures.
I am now working on cutting the bugfix release, it doesn't look like there are any more pending issues to backport. Please follow the usual conventions if you need to backport to this branch including giving a notification here. On Sat, May 9, 2020 at 7:07 AM Adrien Grand <jpou...@gmail.com> wrote: > I'd rather not change signatures on a patch release. Are there ways we > could have the bug fix on 8.5 without backporting this API change? > > On Fri, May 8, 2020 at 5:18 PM Mike Drob <md...@apache.org> wrote: > >> While back porting LUCENE-9350, I ran into needing LUCENE-9349[1] which >> introduces a small API change to QueryVisitor. Do we think this is >> acceptable in a bug fix release, or do I need to figure out how to back >> port the changes without it? >> >> [1]: https://issues.apache.org/jira/browse/LUCENE-9349 >> >> On 2020/05/07 18:30:53, Alan Woodward <romseyg...@gmail.com> wrote: >> > +1, thanks for volunteering Mike >> > >> > > On 7 May 2020, at 19:03, Anshum Gupta <ans...@anshumgupta.net >> <mailto:ans...@anshumgupta.net>> wrote: >> > > >> > > Thanks for doing this, Mike. >> > > +1 to the 8.5.2 release. >> > > >> > > On Thu, May 7, 2020 at 10:13 AM Mike Drob <md...@apache.org <mailto: >> md...@apache.org>> wrote: >> > > Devs, >> > > >> > > I know that we had 8.5.1 only a few weeks ago, but with the fix for >> LUCENE-9350 I think we should consider another bug-fix. I know that without >> it I will be explicitly recommending several users to stay off of 8.5.x on >> their upgrade plans. There are some pretty scary looking charts on >> SOLR-14428 that describe the impact of the bug in more detail. >> > > >> > > I'd be happy to volunteer as RM for this, would probably be looking >> at trying to get it a vote started sometime next week. >> > > >> > > Thanks, >> > > Mike >> > > >> > > >> > > https://issues.apache.org/jira/browse/SOLR-14428 < >> https://issues.apache.org/jira/browse/SOLR-14428> >> > > https://issues.apache.org/jira/browse/LUCENE-9350 < >> https://issues.apache.org/jira/browse/LUCENE-9350> >> > > >> > > --------------------------------------------------------------------- >> > > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org <mailto: >> dev-unsubscr...@lucene.apache.org> >> > > For additional commands, e-mail: dev-h...@lucene.apache.org <mailto: >> dev-h...@lucene.apache.org> >> > > >> > > >> > > >> > > -- >> > > Anshum Gupta >> > >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >> For additional commands, e-mail: dev-h...@lucene.apache.org >> >> > > -- > Adrien >
