+1 Maybe we can add naming rules for test classes on check-source-patterns.groovy? https://github.com/apache/lucene-solr/blob/f03e6aac59cbdb0422aa05047fbc1c4bc5324cd9/lucene/tools/src/groovy/check-source-patterns.groovy
Tomoko 2020年8月6日(木) 12:17 Robert Muir <rcm...@gmail.com>: > +1 > > There is no good reason to name the source files inconsistently. It should > be as easy as possible to do things with the tests with regular > expressions, simple tools like grep and so on. > > Ideally we can fail the build if one tries to get added in the wrong way > (some kind of precommit check: simple test of source patterns or class > names or something?) This way there are no surprises such as tests not > executing and no inconsistencies. > > On Wed, Aug 5, 2020 at 11:02 PM Marcus Eagan <marcusea...@gmail.com> > wrote: > >> Hi community, what do you think a small effort to standardize on leading >> with the word "Test" or trailing with the word "Test" in the repo. Most >> projects do one or the other and it has an impact on developer >> productivity. I'll explain my use case: >> >> I'm working on a class and I want to modify the test to evaluate my >> changes. If the class is named in a standard way, I can find it easily. If >> it is not, it's fine. There are typically two options. I consider it >> distracting and sloppy. Distraction is expensive for developers. I have >> some more important efforts that I'm working on, but if the community >> agrees on this one, I can open a ticket and submit a PR. Let me know what >> you think. >> >> Hoping to make the project more developer friendly. >> >> -- >> Marcus Eagan >> >>
