> Gradlew check takes very long time, as it checks really everything, including 
> building whole javadocs and so on.

It does. And it should? If not, perhaps we shouldn't attach those
validation tasks to the "check" task and have a dedicated "full-check"
for CI
jobs or something.

> $ ./gradlew precommit

Yes, this does work although it's really something that doesn't fit
with anyone familiar with gradle... In gradle world, you'd run a quick
check just on the subproject you touched somehow:

gradlew -p lucene/core check

Running

gradlew check

runs the check task for *all* subprojects that define it. So yes, it
will be quite long.

Dawid


>
> For a quick check, this is more or less identical to Ant.
>
> Uwe
>
> -----
> Uwe Schindler
> Achterdiek 19, D-28357 Bremen
> https://www.thetaphi.de
> eMail: [email protected]
>
> > -----Original Message-----
> > From: Erick Erickson <[email protected]>
> > Sent: Thursday, August 27, 2020 11:11 PM
> > To: [email protected]
> > Subject: Re: Current workflow for steps before commiting changes
> >
> > Alexandre:
> >
> > "./gradlew check” is all you need. That does what “ant precommit test” would
> > do.
> >
> > Dawid put some pretty great help in, "./gradlew help” shows the top-level 
> > help
> > tasks, and “./gradlew helpAnt” gives some very useful gradle versions of 
> > some
> > of the familiar Ant targets you’re used to.
> >
> > And if you want to see _everything_, “./gradlew tasks”, but prepare to be
> > overwhelmed….
> >
> > Best,
> > Erick
> >
> >
> > > On Aug 27, 2020, at 4:38 PM, Alexandre Rafalovitch <[email protected]>
> > wrote:
> > >
> > > Hello,
> > >
> > > So, what's the current post-changes pre-commit workflow for master (9)?
> > >
> > > Do I run gradlew precommit? Does that include actual tests or need
> > > those separately? Do I need to run ant precommit as well?
> > >
> > > I am mostly removing things, but need to make sure no dangling
> > > references will cause issues.
> > >
> > > Regards,
> > >   Alex.
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: [email protected]
> > > For additional commands, e-mail: [email protected]
> > >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [email protected]
> > For additional commands, e-mail: [email protected]
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to